Skip to content

chore(storage): remove unused log4j configuration #6583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2021
Merged

chore(storage): remove unused log4j configuration #6583

merged 1 commit into from
Dec 13, 2021

Conversation

grayside
Copy link
Contributor

@grayside grayside commented Dec 13, 2021 •
edited
Loading

This change removes an unused log4j configuration. This was added in the original commit of the sample without any obvious use. By removing this configuration, I hope to mitigate concerns this sample might be vulnerable, giving developers confidence it's safe to use.

Original Commit

git show 3cd29aa0 -- . | grep log4j
diff --git a/storage/xml-api/serviceaccount-appengine-sample/src/main/resources/log4j.properties b/storage/xml-api/serviceaccount-appengine-sample/src/main/resources/log4j.properties
+++ b/storage/xml-api/serviceaccount-appengine-sample/src/main/resources/log4j.properties
+# A default log4j configuration for log4j users.
+log4j.appender.A1=org.apache.log4j.ConsoleAppender
+log4j.appender.A1.layout=org.apache.log4j.PatternLayout
+log4j.appender.A1.layout.ConversionPattern=%d{HH:mm:ss,SSS} %-5p [%c] - %m%n
+log4j.category.DataNucleus.JDO=WARN, A1
+log4j.category.DataNucleus.Persistence=WARN, A1
+log4j.category.DataNucleus.Cache=WARN, A1
+log4j.category.DataNucleus.MetaData=WARN, A1
+log4j.category.DataNucleus.General=WARN, A1
+log4j.category.DataNucleus.Utility=WARN, A1
+log4j.category.DataNucleus.Transaction=WARN, A1
+log4j.category.DataNucleus.Datastore=WARN, A1
+log4j.category.DataNucleus.ClassLoading=WARN, A1
+log4j.category.DataNucleus.Plugin=WARN, A1
+log4j.category.DataNucleus.ValueGeneration=WARN, A1
+log4j.category.DataNucleus.Enhancer=WARN, A1
+log4j.category.DataNucleus.SchemaTool=WARN, A1

@grayside grayside self-assigned this Dec 13, 2021
@product-auto-label product-auto-label bot added api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels Dec 13, 2021
@averikitsch averikitsch merged commit 7db1b9d into main Dec 13, 2021
@averikitsch averikitsch deleted the storage-xml-api-log4j branch December 13, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averikitsch averikitsch averikitsch approved these changes

Assignees

@grayside grayside

Labels
api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grayside @averikitsch