Skip to content

Update Spring Boot dependencies to 2.5.8 #6600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 22, 2021
Merged

Conversation

elefeint
Copy link
Contributor

@elefeint elefeint commented Dec 22, 2021

The latest Spring Boot release was yesterday; it upgrades log4j-api to 2.17.0.

Do you know why renovate bot does not get to these dependencies?

I also had to upgrade the R2DBC test to JUnit5 -- at some point when spring-boot-test dependency got upgraded to 2.5.x, the test got silently ignored.

  • [x ] Tests pass: mvn clean verify required
  • [x ] Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@elefeint elefeint requested review from yoshi-approver and a team as code owners December 22, 2021 18:44
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 22, 2021
@elefeint
Copy link
Contributor Author

@eaball35 sorry, do you know why spanner.test.instance property is not set when R2dbcSampleApplicationIT runs? It seems to work fine for JdbcExamplesIT.

This test has not run since 6/10 (because Spring Boot Test got upgraded to a version that brought JUnit5 setup, but the test stayed on JUnit4), so things may have changed since then. But locally, it works fine as long as spanner.test.instance is passed.

@anguillanneuf
Copy link
Member

anguillanneuf commented Dec 22, 2021

@elefeint If you want to separate the version update in the Spanner sample into a different PR. We can merge this one for everything else first.

@jsimonweb Will you be able to help with the Spanner test failure? (just realized Jonathan is OOO for three weeks)

@elefeint
Copy link
Contributor Author

That's a good idea; I'll open another PR for fixing tests. I see that dataflow sets the database instance explicitly in maven setup; I might try that, too:

          <systemPropertyVariables>
            <spanner.test.instance>default-instance</spanner.test.instance>
          </systemPropertyVariables>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants