Skip to content

docs: fix Bigtable workload generator (df delete) #6634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 8, 2022
Merged

docs: fix Bigtable workload generator (df delete) #6634

merged 5 commits into from
Feb 8, 2022

Conversation

billyjacobson
Copy link
Member

@billyjacobson billyjacobson commented Jan 10, 2022 •
edited
Loading

updating dataflow delete functionality

Fixes the issue mentioned in #6612 by @kongweihan

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@billyjacobson
docs: fix Bigtable workload generator (df delete)
1f9e234 
updating dataflow delete functionality
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 10, 2022
@billyjacobson billyjacobson marked this pull request as ready for review January 10, 2022 18:28
@billyjacobson billyjacobson requested review from yoshi-approver and a team as code owners January 10, 2022 18:28
@billyjacobson billyjacobson requested a review from kolea2 January 10, 2022 18:48
@billyjacobson
Update README.md
43b7a71 
ask users to list jobs and then delete vs complicated command
@billyjacobson billyjacobson added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 10, 2022
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 10, 2022
kolea2
kolea2 reviewed Jan 11, 2022
View reviewed changes
Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one nit

@billyjacobson
Merge branch 'main' into bt-gen-df-del
ee98ee7 
# Conflicts:
#	bigtable/beam/workload-generator/README.md
@billyjacobson
Rename variable QPS to Rate
c511e0d
@billyjacobson billyjacobson merged commit b84d088 into main Feb 8, 2022
@billyjacobson billyjacobson deleted the bt-gen-df-del branch February 8, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolea2 kolea2 kolea2 approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

@Neenu1995 Neenu1995

Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@billyjacobson @kolea2 @Neenu1995 @kokoro-team