Skip to content

bug(compute): Fixing a small issue with sample region tags #6667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2022
Merged

bug(compute): Fixing a small issue with sample region tags #6667

merged 1 commit into from
Jan 13, 2022

Conversation

rsamborski
Copy link
Member

Fixing a small issue with sample region tags

It's a good idea to open an issue first for discussion.

  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@rsamborski rsamborski requested review from yoshi-approver and a team as code owners January 12, 2022 12:01
@snippet-bot
Copy link

snippet-bot bot commented Jan 12, 2022

Here is the summary of changes.

You are about to add 1 region tag.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 12, 2022
@rsamborski rsamborski changed the title Fixing a small issue with sample region tags bug(compute): Fixing a small issue with sample region tags Jan 12, 2022
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2022
@rsamborski rsamborski added api: compute Issues related to the Compute Engine API. automerge Merge the pull request once unit tests and other checks pass. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jan 12, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 12, 2022
@rsamborski rsamborski merged commit 5947dc2 into main Jan 13, 2022
@rsamborski rsamborski deleted the sample-compute-create-instances-fix branch January 13, 2022 21:10
Sita04 pushed a commit that referenced this pull request Jan 24, 2022
@rsamborski @Sita04
Fixing a small issue with sample region tags in Compute (#6667)
cd830df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-strzelczyk m-strzelczyk m-strzelczyk approved these changes

@Sita04 Sita04 Sita04 approved these changes

@kolea2 kolea2 kolea2 approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

@kolea2 kolea2

Labels
api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rsamborski @m-strzelczyk @Sita04 @kolea2 @kokoro-team