Skip to content

chore: update job tests with retries #6861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 8, 2022
Merged

chore: update job tests with retries #6861

merged 3 commits into from
Mar 8, 2022

Conversation

averikitsch
Copy link
Contributor

Fixes #6829

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@averikitsch averikitsch requested review from a team and yoshi-approver as code owners March 4, 2022 17:18
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Mar 4, 2022
@averikitsch averikitsch added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 4, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 4, 2022
@averikitsch averikitsch added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 4, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 4, 2022
Shabirmean
Shabirmean reviewed Mar 5, 2022
View reviewed changes
Copy link
Member

@Shabirmean Shabirmean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just doing a shadow-review. Left some comments, I might not be fully aware of the background of the issue; so feel free to resolve them if they are not relevant.

kurtisvg
kurtisvg suggested changes Mar 7, 2022
View reviewed changes
Shabirmean
Shabirmean approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@Shabirmean Shabirmean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the changes!

@averikitsch averikitsch added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 7, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 7, 2022
@averikitsch averikitsch requested a review from kurtisvg March 8, 2022 17:06
@averikitsch averikitsch merged commit c5df475 into main Mar 8, 2022
@averikitsch averikitsch deleted the job-tests branch March 8, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shabirmean Shabirmean Shabirmean approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

@kurtisvg kurtisvg

Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

com.example.JobsIntegrationTests: generatesLogs failed
4 participants
@averikitsch @Shabirmean @kurtisvg @kokoro-team