Skip to content

test: update aiplatform FeatureStore timeout + add retries #7540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 5, 2023
Merged

test: update aiplatform FeatureStore timeout + add retries #7540

merged 5 commits into from
Jan 5, 2023

Conversation

kweinmeister
Copy link
Contributor

@kweinmeister kweinmeister commented Jan 5, 2023 •
edited
Loading

This fix reduces the chance of flakiness, but doesn't eliminate it.

  • Extended timeout in a few operations (reusing existing TIMEOUT constant)
  • Added retries to the FeatureStore test classes

If we see continued errors, we should consider:

  • Removing the assertion in the tearDown() method
  • Refactoring the deletion steps into a test method that can be retried.

Fixes #7538
Fixes #7530

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 5, 2023
@kweinmeister kweinmeister changed the title test: doubled delete featurestore timeout test: update aiplatform FeatureStore timeout + add retries Jan 5, 2023
@kweinmeister kweinmeister marked this pull request as ready for review January 5, 2023 22:35
@kweinmeister kweinmeister requested review from a team and yoshi-approver as code owners January 5, 2023 22:35
@kweinmeister kweinmeister merged commit cb46f0c into main Jan 5, 2023
@kweinmeister kweinmeister deleted the issue-7538 branch January 5, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

@averikitsch averikitsch

Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aiplatform.FeatureValuesSamplesTest: testFeatureValuesSamples failed aiplatform.FeaturestoreSamplesTest: testCreateFeaturestoreSample failed
3 participants
@kweinmeister @lesv @averikitsch