docs(compute-samples): adding machine type update and regional disk samples #7707
Conversation
|
Here is the summary of changes. You are about to add 5 region tags.
This comment is generated by snippet-bot.
|
compute/cloud-client/src/main/java/compute/disks/AttachDisk.java
Outdated
Show resolved
Hide resolved
compute/cloud-client/src/main/java/compute/disks/AttachDisk.java
Outdated
Show resolved
Hide resolved
compute/cloud-client/src/main/java/compute/disks/AttachDisk.java
Outdated
Show resolved
Hide resolved
compute/cloud-client/src/main/java/compute/disks/ResizeDisk.java
Outdated
Show resolved
Hide resolved
compute/cloud-client/src/main/java/compute/disks/ResizeRegionalDisk.java
Outdated
Show resolved
Hide resolved
compute/cloud-client/src/main/java/compute/disks/ResizeRegionalDisk.java
Outdated
Show resolved
Hide resolved
|
|
||
| Operation response = instancesClient | ||
| .setMachineTypeAsync(projectId, zone, instanceName, machineTypeRequest) | ||
| .get(3, TimeUnit.MINUTES); |
There was a problem hiding this comment.
Any reason to set 3 minutes for the timeout?
There was a problem hiding this comment.
Followed the same pattern from the other compute samples. No specific reason.
| .get(3, TimeUnit.MINUTES); | ||
|
|
||
| if (response.hasError()) { | ||
| System.out.println("Machine type update failed! " + response); |
There was a problem hiding this comment.
What types of errors do we expect that wouldn't be thrown during the operation? Can we show users how to handle them?
There was a problem hiding this comment.
ditto, Followed the same pattern from the other compute samples.
Python Reference: https://github.com/GoogleCloudPlatform/python-docs-samples/pull/8992/files#diff-9dcee92af6eb54e1cd2c96bbdc292fc4857452f209215aa0204e461c7ee49d9bR62-R69
But AFAIK, I haven't encountered any errors that were not raised as exceptions.
| .setDisksResizeRequestResource(DisksResizeRequest.newBuilder() | ||
| .setSizeGb(newSizeGb) | ||
| .build()) | ||
| .setDisk(match[5]) |
There was a problem hiding this comment.
This doesn't take the full disk resource path? This seems unnecessarily hard. Is there another way to achieve this? If not You should add more comments to why you are using the matcher.
There was a problem hiding this comment.
Yes, I believe this is due to multiple formats being accepted. See: https://github.com/GoogleCloudPlatform/python-docs-samples/pull/8992/files#diff-00f22f3a9fa3fb85b7b4340eaeb0aefece4b60556f7efd7e7bf58d684b496f2bR88-R91
I'll double check this and update the sample. Thanks for calling this out.
There was a problem hiding this comment.
Updated the code to simplify. This will result in code discrepancy between the Java and Python versions. But using matcher is an over-kill for this situation and hence added additional params.
Adding samples needed for this page.