Skip to content

chore: cleanup un-wanted region tags #7751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2023
Merged

chore: cleanup un-wanted region tags #7751

merged 1 commit into from
Mar 18, 2023

Conversation

msampathkumar
Copy link
Member

Description: Old region tags are replaced with product specific region tags. Please check b/272509882 for more details.

New Region tags were added using Pull Request: https://github.com/GoogleCloudPlatform/java-docs-samples/pull/7732/files

Fixes #issue

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@msampathkumar
chore: cleanup un-wanted region tags
1e8916f 
Description: Old region tags are replaced with product specific region tags. Please check b/272509882 for more details.

New Region tags were added using Pull Request: https://github.com/GoogleCloudPlatform/java-docs-samples/pull/7732/files
@msampathkumar msampathkumar requested review from a team and yoshi-approver as code owners March 16, 2023 16:26
@snippet-bot
Copy link

snippet-bot bot commented Mar 16, 2023

Here is the summary of possible violations 😱

There is a possible violation for removing region tag in use.

The end of the violation section. All the stuff below is FYI purposes only.

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Mar 16, 2023
@msampathkumar
Copy link
Member Author

Update: cl/517138087 is recently finished.

@averikitsch averikitsch merged commit e13fbcc into main Mar 18, 2023
@averikitsch averikitsch deleted the b_272509882 branch March 18, 2023 00:03
@msampathkumar
Copy link
Member Author

Thank you @averikitsch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averikitsch averikitsch averikitsch approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

@anguillanneuf anguillanneuf

Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msampathkumar @averikitsch @anguillanneuf