Skip to content

feat: migrating bigquerydatatransfer snippet #8441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2023
Merged

feat: migrating bigquerydatatransfer snippet #8441

merged 2 commits into from
Jul 18, 2023

Conversation

suztomo
Copy link
Contributor

@suztomo suztomo commented Jul 18, 2023 •
edited
Loading

Migrating the snippet files from
https://github.com/googleapis/java-bigquerydatatransfer/tree/f0f22ce/samples/snippets.

Memo: Before this migration, the test was succeeding in java-bigquerydatatransfer repository: https://source.cloud.google.com/results/invocations/5dca9d6a-cd83-4c3c-8bc5-3e73fb64526b

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@suztomo suztomo requested review from a team and yoshi-approver as code owners July 18, 2023 18:21
@snippet-bot
Copy link

snippet-bot bot commented Jul 18, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 27 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: bigquery Issues related to the BigQuery API. labels Jul 18, 2023
@suztomo suztomo marked this pull request as draft July 18, 2023 18:21
@suztomo
Copy link
Contributor Author

suztomo commented Jul 18, 2023

The tests failed:

[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0 s <<< FAILURE! - in com.example.bigquerydatatransfer.DisableTransferConfigIT
[ERROR] com.example.bigquerydatatransfer.DisableTransferConfigIT  Time elapsed: 0 s  <<< FAILURE!
junit.framework.AssertionFailedError: Environment variable DTS_TRANSFER_CONFIG_NAME is required to perform these tests.
	at com.example.bigquerydatatransfer.DisableTransferConfigIT.requireEnvVar(DisableTransferConfigIT.java:46)
	at com.example.bigquerydatatransfer.DisableTransferConfigIT.<clinit>(DisableTransferConfigIT.java:42)
...

[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.004 s <<< FAILURE! - in com.example.bigquerydatatransfer.CreateAmazonS3TransferIT
[ERROR] com.example.bigquerydatatransfer.CreateAmazonS3TransferIT  Time elapsed: 0 s  <<< FAILURE!
junit.framework.AssertionFailedError: Environment variable AWS_BUCKET is required to perform these tests.
	at com.example.bigquerydatatransfer.CreateAmazonS3TransferIT.requireEnvVar(CreateAmazonS3TransferIT.java:68)
	at com.example.bigquerydatatransfer.CreateAmazonS3TransferIT.<clinit>(CreateAmazonS3TransferIT.java:64)

@suztomo suztomo marked this pull request as ready for review July 18, 2023 18:49
@Sita04
Copy link
Contributor

Sita04 commented Jul 18, 2023

Looks like Quota issue

RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Other requests for Data Transfer Service' and limit 'Other requests for Data Transfer Service per minute per user' of service 'bigquerydatatransfer.googleapis.com' for consumer 'project_number:

@suztomo
Copy link
Contributor Author

suztomo commented Jul 18, 2023

Thank you for checking the error. Right, it seems so. "Java 8" and "Java 11" succeeded.

@suztomo
Copy link
Contributor Author

suztomo commented Jul 18, 2023

Now Java 17 succeeded with a retry.

@Sita04
Copy link
Contributor

Sita04 commented Jul 18, 2023

Requested quota increase for the metric. Should be reflected in a couple days.

@Sita04 Sita04 merged commit 246d11e into GoogleCloudPlatform:main Jul 18, 2023
@suztomo suztomo deleted the add_bigquerydatatransfer branch July 18, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sita04 Sita04 Sita04 approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

@minherz minherz

Labels
api: bigquery Issues related to the BigQuery API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suztomo @Sita04 @minherz