Skip to content

fix(healthcare): don't store DICOM instance before each DICOMweb test #9292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2024
Merged

fix(healthcare): don't store DICOM instance before each DICOMweb test #9292

merged 2 commits into from
Apr 17, 2024

Conversation

noerog
Copy link
Contributor

@noerog noerog commented Apr 17, 2024

Description

Only store DICOM instance once for all DICOMweb tests. Previously, storing a duplicate instance returned a 200, but it now returns a 409, causing tests to fail.

The JUnit4 MethodSorters (https://junit.org/junit4/javadoc/4.12/org/junit/runners/MethodSorters.html) functionality is also incorrectly running the DicomWebDeleteStudy test too early, even though its name was modified so that it ran last in the NAME_ASCENDING order, so update each test's name to ensure that they run in order.

Fixes

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • [] Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@noerog noerog requested review from yoshi-approver and a team as code owners April 17, 2024 04:39
@product-auto-label product-auto-label bot added api: healthcare Issues related to the Cloud Healthcare API API. samples Issues that are directly related to samples. api: healhcare labels Apr 17, 2024
@kweinmeister kweinmeister merged commit 5752f77 into main Apr 17, 2024
@kweinmeister kweinmeister deleted the dicomweb-fix branch April 17, 2024 16:28
rafaelMurata pushed a commit to rafaelMurata/java-docs-samples that referenced this pull request May 7, 2024
@noerog
fix(healthcare): don't store DICOM instance before each DICOMweb test (…
9f171a9 
…GoogleCloudPlatform#9292)

* fix(healthcare): don't store DICOM instance before each DICOMweb test

* fix lint issues and remove @SuppressWarnings on method name because it's now technically valid
rafaelMurata pushed a commit to rafaelMurata/java-docs-samples that referenced this pull request May 27, 2024
@noerog
fix(healthcare): don't store DICOM instance before each DICOMweb test (…
a97559a 
…GoogleCloudPlatform#9292)

* fix(healthcare): don't store DICOM instance before each DICOMweb test

* fix lint issues and remove @SuppressWarnings on method name because it's now technically valid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbeaudreau danielbeaudreau danielbeaudreau approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

@danielbeaudreau danielbeaudreau

Labels
api: healthcare Issues related to the Cloud Healthcare API API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noerog @danielbeaudreau @kweinmeister