Skip to content

Use long-flags everywhere, for readability. #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2017
Merged

Use long-flags everywhere, for readability. #970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions endpoints/getting-started-grpc/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,20 +78,22 @@ and [SDK](https://cloud.google.com/sdk/) configured.

```bash
/usr/share/google/dockercfg_update.sh
docker run -d --name=grpc-hello gcr.io/${GCLOUD_PROJECT}/java-grpc-hello:1.0
docker run --detach --name=grpc-hello gcr.io/${GCLOUD_PROJECT}/java-grpc-hello:1.0
```

1. Run the Endpoints proxy

```bash
docker run --detach --name=esp \
-p 80:9000 \
docker run \
--detach \
--name=esp \
--publish 80:9000 \
--link=grpc-hello:grpc-hello \
gcr.io/endpoints-release/endpoints-runtime:1 \
-s ${SERVICE_NAME} \
-v ${SERVICE_CONFIG_ID} \
-P 9000 \
-a grpc://grpc-hello:50051
--service=${SERVICE_NAME} \
--version=${SERVICE_CONFIG_ID} \
--http2_port=9000 \
--backend=grpc://grpc-hello:50051
```

1. Back on your local machine, get the external IP of your GCE instance.
Expand Down
8 changes: 4 additions & 4 deletions endpoints/getting-started-grpc/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ spec:
- name: esp
image: gcr.io/endpoints-release/endpoints-runtime:1
args: [
"-P", "9000",
"-a", "grpc://127.0.0.1:50051",
"-s", "SERVICE_NAME",
"-v", "SERVICE_CONFIG_ID",
"--http2_port=9000",
"--backend=grpc://127.0.0.1:50051",
"--service=SERVICE_NAME",
"--version=SERVICE_CONFIG_ID",
]
ports:
- containerPort: 9000
Expand Down
8 changes: 4 additions & 4 deletions endpoints/getting-started/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ spec:
- name: esp
image: gcr.io/endpoints-release/endpoints-runtime:1
args: [
"--http_port", "8081",
"--backend", "127.0.0.1:8080",
"--service", "SERVICE_NAME",
"--version", "SERVICE_CONFIG_ID",
"--http_port=8081",
"--backend=127.0.0.1:8080",
"--service=SERVICE_NAME",
"--version=SERVICE_CONFIG_ID",
]
# [END esp]
ports:
Expand Down
8 changes: 4 additions & 4 deletions endpoints/multiple-versions/container-engine.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ spec:
- name: esp
image: gcr.io/endpoints-release/endpoints-runtime:1
args: [
"-p", "8081",
"-a", "127.0.0.1:8080",
"-s", "SERVICE_NAME",
"-v", "SERVICE_CONFIG_ID",
"--http_port=8081",
"--backend=127.0.0.1:8080",
"--service=SERVICE_NAME",
"--version=SERVICE_CONFIG_ID",
]
# [END esp]
ports:
Expand Down