Skip to content

Conversation

alarconesparza
Copy link
Contributor

@alarconesparza alarconesparza commented Jan 21, 2025

Description

Fixes
Internal b/390238528

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples. labels Jan 21, 2025
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request, "chore(compute): remove old region tag", aims to clean up the compute/mailjet sample by removing outdated region tags. Specifically, the changes involve removing the // [START app] and // [END app] comments from MailjetSender.java.

Here's a breakdown of the changes:

  • File: compute/mailjet/src/main/java/com/example/compute/mailjet/MailjetSender.java
    • Removed lines 33 and 85, which contained the // [START app] and // [END app] comments respectively.
    • Before:
30:// [END compute_mailjet_imports]
31:
32:// [START compute_mailjet_send_email]
33:// [START app]
34:public class MailjetSender {
35:
36:  public static void main(String[] args) throws MailjetException {
...
82:    }
83:  }
84:}
85:// [END app]
86:// [END compute_mailjet_send_email]
* After:
30:// [END compute_mailjet_imports]
31:
32:// [START compute_mailjet_send_email]
33:public class MailjetSender {
34:
35:  public static void main(String[] args) throws MailjetException {
...
81:    }
82:  }
83:}
84:// [END compute_mailjet_send_email]

The author, alarconesparza, has also completed the checklist provided in the PR description, indicating that tests and lint checks have passed.


A little haiku to brighten your day:

Old tags now removed,
Code cleaner, bright and new,
Review can begin.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request removes the app tag in MailjetSender.java, which seems like a cleanup task. The changes are minimal and straightforward. However, the description could be improved to clearly state the purpose of removing the tag and its impact. Additionally, the checklist items should be updated to reflect the actual changes made in this PR.

Here's a summary of the style guide elements I referenced:

  • Google Java Style Guide: I checked for adherence to general Java conventions, including naming, formatting, and documentation.

Specific recommendations based on the style guide:

  • Documentation: The PR description should be more descriptive.
  • Checklist: The checklist should be updated.

Overall, the code changes are minor and look correct. However, improving the PR description and checklist will enhance clarity and maintainability.

@alarconesparza alarconesparza marked this pull request as ready for review January 21, 2025 19:20
@alarconesparza alarconesparza requested review from yoshi-approver and a team as code owners January 21, 2025 19:20
Copy link

snippet-bot bot commented Jan 21, 2025

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@telpirion telpirion merged commit 9b9a53c into GoogleCloudPlatform:main Jan 23, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants