Skip to content

fix: more retries #10624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2023
Merged

fix: more retries #10624

merged 1 commit into from
Oct 2, 2023

Conversation

engelke
Copy link
Contributor

@engelke engelke commented Sep 14, 2023

Description

Fixes #10621

@engelke engelke requested review from a team as code owners September 14, 2023 16:58
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: jobs Issues related to the Cloud Talent Solution Job Search API. labels Sep 14, 2023
@engelke engelke added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 14, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 14, 2023
rsamborski
rsamborski reviewed Sep 15, 2023
View reviewed changes
Copy link
Member

@rsamborski rsamborski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be not enough as the sample failed 4 times in PR test runs. We might need to consider a different way to approach it.

@engelke engelke added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2023
@rsamborski rsamborski merged commit b965d49 into main Oct 2, 2023
@rsamborski rsamborski deleted the flaky-10621 branch October 2, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsamborski rsamborski rsamborski approved these changes

@holtskinner holtskinner holtskinner approved these changes

Assignees

@m-strzelczyk m-strzelczyk

Labels
api: jobs Issues related to the Cloud Talent Solution Job Search API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jobs.v3.api_client.histogram_sample_test: test_histogram_sample failed
5 participants
@engelke @rsamborski @holtskinner @m-strzelczyk @kokoro-team