Skip to content

fix(generative-ai): Add tests for function_calling code snippet #11019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 13, 2023
Merged

fix(generative-ai): Add tests for function_calling code snippet #11019

merged 10 commits into from
Dec 13, 2023

Conversation

koverholt
Copy link
Member

@koverholt koverholt commented Dec 13, 2023 •
edited
Loading

Description

Fixes #11018 by adding tests on function calling output.

Checklist

@koverholt koverholt requested review from a team as code owners December 13, 2023 00:40
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Dec 13, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 13, 2023
msampathkumar
msampathkumar reviewed Dec 13, 2023
View reviewed changes
msampathkumar
msampathkumar reviewed Dec 13, 2023
View reviewed changes
@koverholt
Copy link
Member Author

Tests are currently failing because this functionality just landed in google-cloud-aiplatform==1.38.0 earlier today, whereas an older version of that client lib is being used in the tests. Also, tests will run against APIs that are not yet available but are scheduled to go live tomorrow.

cc @polong-lin

@msampathkumar
Copy link
Member

@koverholt CICD failing with below error. To fix, please update the required package in requriements.txt file

ModuleNotFoundError: No module named 'vertexai.preview.generative_models

@koverholt
Copy link
Member Author

Thanks for the note! I updated the package version of google-cloud-aiplatform to 1.38.0, and now am hitting an (expected) permissions error for an allowlisted API that will be made public tomorrow. I can check back on this PR and re-run tests tomorrow.

@msampathkumar
Copy link
Member

@koverholt Almost there! Check the error below

Project 1012616486416 is not allowed to use Publisher Model `projects/python-docs-samples-tests/locations/us-central1/publishers/google/models/gemini-pro

@kweinmeister kweinmeister merged commit bb3b34f into main Dec 13, 2023
@kweinmeister kweinmeister deleted the generative-ai-function-calling-tests branch December 13, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msampathkumar msampathkumar msampathkumar left review comments

@kweinmeister kweinmeister kweinmeister approved these changes

Assignees

@kweinmeister kweinmeister

Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing test
3 participants
@koverholt @msampathkumar @kweinmeister