Skip to content

feat: add code samples for distillation #11156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 12, 2024
Merged

feat: add code samples for distillation #11156

merged 3 commits into from
Feb 12, 2024

Conversation

liulehui
Copy link
Contributor

@liulehui liulehui commented Jan 29, 2024 •
edited
Loading

Description

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@liulehui liulehui requested review from a team as code owners January 29, 2024 22:49
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Jan 29, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 29, 2024
@m-strzelczyk m-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 9, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 9, 2024
@m-strzelczyk
Copy link
Contributor

Code looks good, but you need to fix it so it passes the tests.

______________________________ test_distill_model ______________________________
Traceback (most recent call last):
  File "/workspace/generative_ai/distillation_test.py", line 94, in test_distill_model
    student_model = distillation.distill_model(
TypeError: distill_model() got an unexpected keyword argument 'training_data'

The gemini tests we just have to accept are quite unpredictable, but the failure above is important.

@liulehui liulehui requested a review from m-strzelczyk February 9, 2024 15:18
@liulehui
Copy link
Contributor Author

liulehui commented Feb 9, 2024

Thank you @m-strzelczyk
I fixed the test, how should I kick off the Kokoro CI?

@m-strzelczyk m-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 9, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 9, 2024
@m-strzelczyk
Copy link
Contributor

@liulehui adding the kokoro:force-run label triggers the checks to rerun :)

@liulehui
Copy link
Contributor Author

liulehui commented Feb 9, 2024

@m-strzelczyk Thank you, fixed another, thanks so much for reviewing it!

@m-strzelczyk m-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 11, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 11, 2024
@m-strzelczyk
Copy link
Contributor

I'm gonna merge this, since it seems the errors we have are not related to those samples.

@m-strzelczyk m-strzelczyk merged commit cee3e73 into GoogleCloudPlatform:main Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-strzelczyk m-strzelczyk Awaiting requested review from m-strzelczyk

Assignees

@m-strzelczyk m-strzelczyk

Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liulehui @m-strzelczyk @kokoro-team