Skip to content

fix: compute template test issue #11166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2024
Merged

fix: compute template test issue #11166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe3c446
fix: compute template test issue
m-strzelczyk Feb 2, 2024
dfdc718
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions compute/client_library/ingredients/instances/create_instance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,9 @@ def create_instance(
instance.scheduling = compute_v1.Scheduling()
if accelerators:
instance.guest_accelerators = accelerators
instance.scheduling.on_host_maintenance = compute_v1.Scheduling.OnHostMaintenance.TERMINATE.name
instance.scheduling.on_host_maintenance = (
compute_v1.Scheduling.OnHostMaintenance.TERMINATE.name
)

if preemptible:
# Set the preemptible setting
Expand All @@ -126,7 +128,7 @@ def create_instance(
)
instance.scheduling = compute_v1.Scheduling()
instance.scheduling.preemptible = True

if spot:
# Set the Spot VM setting
instance.scheduling.provisioning_model = (
Expand Down
5 changes: 4 additions & 1 deletion compute/client_library/snippets/tests/test_templates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,10 @@ def test_create_template_and_list(deletable_template_name):
)
assert template.properties.disks[0].initialize_params.disk_size_gb == 250
assert "debian-11" in template.properties.disks[0].initialize_params.source_image
assert template.properties.network_interfaces[0].name == "global/networks/default"
assert template.properties.network_interfaces[0].name == "nic0"
assert template.properties.network_interfaces[0].network.endswith(
"global/networks/default"
)
assert template.properties.machine_type == "e2-standard-4"


Expand Down