feat(soft-delete-cost-analysis): Script to identify buckets with relative increase in cost on enabling the soft-delete. #11197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Combines storage/v2/deleted_bytes and storage/v2/total_byte_seconds for analysis.
* Formula for relative cost:
('soft delete retention duration' × 'deleted bytes' / 'total bytes')
x 'cost of storing in storage class' x 'ratio of storage class'
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
engelke
approved these changes
Feb 12, 2024
storage/cost-analysis/storage_soft_delete_relative_cost_analyzer.py
Outdated
Show resolved
Hide resolved
storage/cost-analysis/storage_soft_delete_relative_cost_analyzer.py
Outdated
Show resolved
Hide resolved
storage/cost-analysis/storage_soft_delete_relative_cost_analyzer.py
Outdated
Show resolved
Hide resolved
engelke
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identifies buckets with relative increase in cost on enabling the soft-delete. The relative increase in cost of using soft delete is calculated by combining the storage/v2/deleted_bytes metric with the existing storage/v2/total_byte_seconds metric.
Relative cost of each bucket = ('soft delete retention duration'
× 'deleted bytes' / 'total bytes seconds' )
x 'cost of storing in storage class'
x 'ratio of storage class'.
Description
Fixes #11196
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)