Skip to content

Managed kafka code samples #11994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 15, 2024
Merged

Managed kafka code samples #11994

merged 5 commits into from
Jul 15, 2024

Conversation

luongadam
Copy link
Contributor

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@luongadam luongadam requested review from a team as code owners July 2, 2024 18:39
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Jul 2, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 14 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jul 2, 2024
@m-strzelczyk m-strzelczyk assigned m-strzelczyk and unassigned nicain Jul 11, 2024
m-strzelczyk
m-strzelczyk requested changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@m-strzelczyk m-strzelczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments, only one is a potentially real issue with the code. Rest is more stylistic/organizational.

There are 2 more things to address:

  1. You didn't provide requirements.txt in this PR in the managedkafka/snippets folder, so Koko doesn't run tests for this folder. Please provide requirements.txt to have Koko run the tests.
  2. I personally like when my list and get methods return the values they're getting/listing. Making it so, provides users with clear indication with what kind of results they will deal with.

@m-strzelczyk m-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 15, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 15, 2024
@m-strzelczyk m-strzelczyk merged commit b97d17e into GoogleCloudPlatform:main Jul 15, 2024
@luongadam luongadam deleted the managed-kafka-code-samples branch July 15, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-strzelczyk m-strzelczyk m-strzelczyk approved these changes

Assignees

@m-strzelczyk m-strzelczyk

Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luongadam @m-strzelczyk @nicain @kokoro-team