Skip to content

Fixed b/65407087 #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 8, 2017
Merged

Fixed b/65407087 #1206

merged 2 commits into from
Nov 8, 2017

Conversation

michaelawyu
Copy link
Contributor

Import flask as a built-in third-party library

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2017
@michaelawyu michaelawyu requested a review from theacodes November 8, 2017 00:18
theacodes
theacodes reviewed Nov 8, 2017
View reviewed changes
appengine/standard/flask/hello_world/app.yaml Outdated

libraries:
- name: flask
version: latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pin a specific version here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added :)

@theacodes theacodes merged commit 2d2ee1c into GoogleCloudPlatform:master Nov 8, 2017
@zjn0505 zjn0505 mentioned this pull request Nov 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@theacodes theacodes theacodes approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelawyu @theacodes @googlebot