Skip to content

Do not base64 encode the input content. #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2017
Merged

Do not base64 encode the input content. #1241

merged 1 commit into from
Dec 1, 2017

Conversation

lukesneeringer
Copy link
Contributor

Protobuf handles the base64 encoding for you, and so the content was being base64 encoded twice.

@lukesneeringer
Do not base64 encode the input content.
9d3f6bb 
Protobuf handles the base64 encoding for you, and so the content was being base64 encoded twice.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 1, 2017
@theacodes theacodes merged commit d63c12c into GoogleCloudPlatform:master Dec 1, 2017
@lukesneeringer lukesneeringer deleted the patch-1 branch December 1, 2017 01:23
busunkim96 pushed a commit to busunkim96/python-videointelligence that referenced this pull request May 20, 2020
@lukesneeringer
Do not base64 encode the input content. [(#1241)](GoogleCloudPlatform…
8b1c7b7 
…/python-docs-samples#1241)

Protobuf handles the base64 encoding for you, and so the content was being base64 encoded twice.
danoscarmike pushed a commit to googleapis/python-videointelligence that referenced this pull request Sep 30, 2020
@lukesneeringer @danoscarmike
Do not base64 encode the input content. [(#1241)](GoogleCloudPlatform…
2efb43c 
…/python-docs-samples#1241)

Protobuf handles the base64 encoding for you, and so the content was being base64 encoded twice.
dizcology pushed a commit that referenced this pull request Sep 11, 2023
@lukesneeringer @danoscarmike
Do not base64 encode the input content. [(#1241)](#1241)
09522f6 
Protobuf handles the base64 encoding for you, and so the content was being base64 encoded twice.
@dizcology dizcology mentioned this pull request Sep 11, 2023
Merged
9 tasks
leahecole pushed a commit that referenced this pull request Sep 15, 2023
@lukesneeringer @leahecole
Do not base64 encode the input content. [(#1241)](#1241)
ff9db3e 
Protobuf handles the base64 encoding for you, and so the content was being base64 encoded twice.
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Sep 22, 2023
@lukesneeringer @danoscarmike
Do not base64 encode the input content. [(#1241)](GoogleCloudPlatform…
7b4fb62 
…/python-docs-samples#1241)

Protobuf handles the base64 encoding for you, and so the content was being base64 encoded twice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beccasaurus beccasaurus beccasaurus approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukesneeringer @beccasaurus @theacodes @googlebot