fix(generative_ai): fix typos in function calling sample #12679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generative_ai/function_calling/parallel_function_calling_example.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Nits:
- Please remove the empty line before
# [END generativeaionvertexai_function_calling_generate_parallel_calls] - Add an empty line after
import vertexai
There was a problem hiding this comment.
- Looks like a common problem in many samples. Curious if it can or should be enforced by the linter 🤔 Fixed my 5 cases manually.
- Also a common problem.
I can check what's up with our lint/import-order, I guess 😺
UPD: I don't see anything for this inflake8-import-order, unfortunately.I201will not identify this as a separate import group — they're both 3rd-parties. For now, fixed manually.
parallel_function_calling sample (typo, long lines)|
CICD error - As suggested, let us check and re-run this after sometime. |
…le.py Improve wording Co-authored-by: Sampath Kumar <sam1990kumar@gmail.com>
msampathkumar
approved these changes
Oct 9, 2024
jacspa96
pushed a commit
to jacspa96/python-docs-samples
that referenced
this pull request
Oct 30, 2024
…Platform#12679) * Fix typos in the function declaration 'description'; wrap long line * Code formatting in generative_ai/function_calling/parallel_function_calling_example.py Co-authored-by: Sampath Kumar <sam1990kumar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes minor issues in the
function_calling/parallel_function_calling_exampleChecklist
nox -s py-3.8&nox -s py-3.11nox -s lint