fix message.payload str casting. #1313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gguuss can you take a look at this? |
gguuss
reviewed
Feb 16, 2018
| @@ -121,7 +121,7 @@ def on_subscribe(self, unused_client, unused_userdata, unused_mid, | |||
|
|
|||
| def on_message(self, unused_client, unused_userdata, message): | |||
| """Callback when the device receives a message on a subscription.""" | |||
| payload = str(message.payload) | |||
| payload = message.payload | |||
| print('Received message \'{}\' on topic \'{}\' with Qos {}'.format( | |||
| payload, message.topic, str(message.qos))) | |||
There was a problem hiding this comment.
Should you remove the str(message.qos) from this line too?
There was a problem hiding this comment.
A string formatter will automatically cast it into string. So, it could be an useless casting, but really doesn't matter. (message.qos is an int type, I guess)
The perfect printing might be like
print('Received message \'{}\' on topic \'{}\' with Qos {}'.format(
payload.decode(), message.topic, message.qos))But exposing type of payload could be useful to specify that it is a byte type.
Therefore, it just depends on the author's intention, just for logging or providing extra information though the log.
gguuss
approved these changes
Feb 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Env: Python 3.6.4 (default, Jan 6 2018, 11:51:59)
[GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)] on darwin
cloudiot_pubsub_example_mqtt_device.py.py in iot end_to_end_example contains wrong str casting.
json.loads takes byte parameter, so you don't have to cast for using it.
If you really want to convert byte to string, it should be
current version produces an error
File "cloudiot_pubsub_example_mqtt_device.py", line 136, in on_message data = json.loads(payload) File "/usr/local/Cellar/python3/3.6.4_2/Frameworks/Python.framework/Versions/3.6/lib/python3.6/json/__init__.py", line 354, in loads return _default_decoder.decode(s) File "/usr/local/Cellar/python3/3.6.4_2/Frameworks/Python.framework/Versions/3.6/lib/python3.6/json/decoder.py", line 339, in decode obj, end = self.raw_decode(s, idx=_w(s, 0).end()) File "/usr/local/Cellar/python3/3.6.4_2/Frameworks/Python.framework/Versions/3.6/lib/python3.6/json/decoder.py", line 357, in raw_decode raise JSONDecodeError("Expecting value", s, err.value) from None json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)