docs(generative_ai): Remove inference folder (duplicate samples)
#13247
Conversation
|
Here is the summary of changes. You are about to delete 4 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Hello @holtskinner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request removes the inference folder, which contains duplicate samples. This resolves the issue reported in b/404290818. The changes involve deleting several files related to inference examples, including test files, source code files, and requirements files.
Highlights
- Removal of Duplicate Samples: The primary goal of this PR is to remove the
inferencefolder containing duplicate samples, cleaning up the codebase. - File Deletion: Multiple files related to inference examples have been deleted, including Python source files, test files, and requirements files.
Changelog
Click here to see the changelog
- generative_ai/inference/inference_api_test.py
- Removed the entire file, which contained tests for the inference API.
- generative_ai/inference/non_stream_multimodality_basic.py
- Removed the entire file, which contained a basic non-stream multimodal inference example.
- generative_ai/inference/non_stream_text_basic.py
- Removed the entire file, which contained a basic non-stream text inference example.
- generative_ai/inference/noxfile_config.py
- Removed the entire file, which contained the noxfile configuration.
- generative_ai/inference/requirements-test.txt
- Removed the entire file, which contained test requirements.
- generative_ai/inference/requirements.txt
- Removed the entire file, which contained the requirements for the inference examples.
- generative_ai/inference/stream_multimodality_basic.py
- Removed the entire file, which contained a basic stream multimodal inference example.
- generative_ai/inference/stream_text_basic.py
- Removed the entire file, which contained a basic stream text inference example.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A folder of samples, now gone,
Duplicates vanished, a new dawn.
Codebase cleaner, a joyful sight,
Inference samples, taking flight.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request aims to remove duplicate samples located in the inference folder. This cleanup helps in maintaining a single source of truth for the samples, which is a good practice. The changes involve deleting several files related to inference examples.
Merge Readiness
The pull request removes duplicate samples, which should simplify maintenance and reduce confusion. Since the changes involve deleting files, it's crucial to ensure that these files are indeed duplicates and not used elsewhere. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging. Given the nature of the changes (file deletions), it would be prudent to have a second pair of eyes confirm the correctness of the removal.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Description
Fixes b/404290818