-
Notifications
You must be signed in to change notification settings - Fork 6.5k
chore(deps): update dependency redis to v6 #13331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency redis to v6 #13331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the redis
dependency from version 5.2.1 to 6.0.0 in two requirements.txt
files. The first file is functions/memorystore/redis/requirements.txt
and the second is memorystore/redis/requirements.txt
. This update likely includes bug fixes, new features, performance improvements, and potentially breaking changes as outlined in the release notes for redis-py
version 6.0.0.
Highlights
- Dependency Update: The core change is updating the
redis
Python library to the latest major version 6.0.0. - Potential Breaking Changes: The release notes indicate several breaking changes, including changes to default values, removal of deprecated features, and modifications to retry strategies. These changes may require updates to the application code to ensure compatibility.
- New Features and Bug Fixes: Version 6.0.0 introduces new features such as new hash commands with expiration options, and includes numerous bug fixes and maintenance improvements.
Changelog
- functions/memorystore/redis/requirements.txt
- Updated
redis
dependency from version 5.2.1 to 6.0.0 on line 2.
- Updated
- memorystore/redis/requirements.txt
- Updated
redis
dependency from version 5.2.1 to 6.0.0 on line 16.
- Updated
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A Redis upgrade's call,
From five to version six, all.
New features gleam,
Or so it would seem,
But breaking changes enthrall.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR updates the redis
dependency to version 6.0.0 in two requirements.txt
files. The update itself seems straightforward, but it's important to consider the potential breaking changes and deprecations introduced in the new version, as outlined in the release notes.
Summary of Findings
- Potential Breaking Changes: The
redis-py
v6.0.0 release includes breaking changes such as the change in default value forssl_check_hostname
toTrue
, mandatoryretry
object for cluster clients, removal ofcharset
anderrors
inputs, and removal of support for RedisGears and RedisGraph modules. It's crucial to ensure that the application code is compatible with these changes. - Retry Configuration: The update changes the default retry strategy for standalone clients to 3 retries with ExponentialWithJitterBackoff. For cluster clients, a
retry
object becomes mandatory. These changes might affect the application's resilience to transient errors and should be carefully evaluated. - Removed Features: The removal of RedisGears and RedisGraph support could impact the application if it relies on these modules. A migration plan or alternative implementation might be necessary.
Merge Readiness
The pull request updates the redis
dependency to v6.0.0. While the update itself is simple, the release notes indicate several breaking changes, deprecations, and feature removals. Before merging, it's essential to ensure that the application code is compatible with these changes and that any necessary migrations or adjustments have been made. I am unable to approve this pull request, and recommend that others review and approve this code before merging.
This PR contains the following updates:
==5.2.1
->==6.0.0
Release Notes
redis/redis-py (redis)
v6.0.0
: 6.0.0Compare Source
Changes
🚀 New Features
🧪 Experimental Features
🔥 Breaking changes
Important: When instantiating a cluster client
retry
object becomes mandatory.Important: Be aware that the query dialect may impact the results returned. If needed, you can revert to a different dialect version by configuring the client accordingly. You can find further details in the query dialect documentation.
🐛 Bug Fixes
🧰 Maintenance
Contributors
We'd like to thank all the contributors who worked on this release!
@elena-kolevska @petyaslavova @vladvildanov @andy-stark-redis @JimNero009 @donbowman @julianolm @666romeo @three-kinds @bssyousefi @mbilski @Yard1 @bacchuswng @noirbee @nbertram @birthdaysgift @Perlence @excitoon @dimbleby @shenxiangzhuang @paololazzari @dwdougherty @niklasbec @byeongjulee222 @befeleme @djroze @BaseMax @dicej @akx @cavemanpi @lattwood @rbs333 @rohansingh @allrob23
v5.3.0
: 5.3.0Compare Source
Changes
🚀 New Features
Token-based authentication:
New StreamingCredentialProvider interface was added with an idea to integrate redis-py with credential providers that stream an events that should be handled by given listeners.
Check the documentation for the quick start guide.
CredentialProvider instance creation interface was enhanced. Feel free to check the updated documentation
Other features:
🐛 Bug Fixes
🧰 Maintenance
Contributors
We'd like to thank all the contributors who worked on this release!
@uglide @woutdenolf @vladvildanov @hauntsaninja @dwdougherty @patrick91 @Vulwsztyn @JimNero009 @andy-stark-redis @petyaslavova
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.