-
Notifications
You must be signed in to change notification settings - Fork 6.6k
feat(run): add FastMCP MCP server sample #13425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @jackwotherspoon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new sample application showcasing the deployment of a remote Model Context Protocol (MCP) server built with FastMCP onto Google Cloud Run. The sample includes a basic math server with 'add' and 'subtract' tools, along with all necessary files for containerization, dependency management using uv, and comprehensive documentation covering deployment steps, authentication, and testing. This sample is intended to accompany an upcoming blog post.
Highlights
- New Sample: Added a new sample directory
run/mcp-server
demonstrating how to deploy a remote MCP server to Google Cloud Run. - FastMCP Server Implementation: Included a simple Python FastMCP server (
server.py
) with basicadd
andsubtract
tools, configured to run using thestreamable-http
transport. - Cloud Run Deployment Setup: Provided a
Dockerfile
for containerizing the Python application and a detailedREADME.md
with instructions for deploying the server to Cloud Run, including notes on authentication and using thegcloud run services proxy
. - Dependency Management: Configured project dependencies using
pyproject.toml
anduv
, including auv.lock
file for reproducible builds. - Testing Script: Added a
test_server.py
script using the FastMCP client to demonstrate how to interact with the deployed remote server.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a sample FastMCP server designed for deployment on Google Cloud Run. The changes include the server application logic (server.py
), a client for testing (test_server.py
), Docker configuration (Dockerfile
, .dockerignore
), project dependencies (pyproject.toml
, uv.lock
), and comprehensive documentation (README.md
).
The overall implementation is clear and demonstrates the setup effectively. Key strengths include the use of uv
for dependency management with a lock file for reproducibility, and a well-written README.
My review includes suggestions to ensure runtime correctness related to port handling and to improve build stability by pinning a base image version in the Dockerfile. These suggestions align with common Python best practices (like type safety) and Dockerfile best practices for creating stable and reproducible container images.
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
Simple remote MCP server sample deployed to Cloud Run 🚀 ☁️
This accompanies a blog that will go live in the next day or two.