Skip to content

update redact_image, quickstart samples #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 13, 2018
Merged

update redact_image, quickstart samples #1399

merged 3 commits into from
Mar 13, 2018

Conversation

andrewsg
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 13, 2018
theacodes
theacodes suggested changes Mar 13, 2018
View reviewed changes
dlp/quickstart.py Outdated
dlp = google.cloud.dlp_v2beta1.DlpServiceClient()
dlp = google.cloud.dlp.DlpServiceClient()

# Pull the project ID from an environment variable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, don't do this. I would just prefer you to do:

project = 'YOUR_PROJECT'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@andrewsg andrewsg merged commit f9f09ce into GoogleCloudPlatform:dlp Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@theacodes theacodes theacodes approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@ace-n ace-n

@averikitsch averikitsch

@michaelawyu michaelawyu

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andrewsg @theacodes @ace-n @googlebot @averikitsch @michaelawyu