Fixed Initialize Firebase section and add snippet #1512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RE: https://cloud.google.com/appengine/docs/standard/python/authenticating-users-firebase-appengine#adding_the_firebase_authentication_user_interface This fails because the projectId and messagingSenderId are missing. I have also added snippet anchors to include snippet in the doc.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
Registered id for cla |
|
CLAs look good, thanks! |
|
/assign @andrewsg |
andrewsg
requested changes
Jun 6, 2018
| @@ -19,15 +19,19 @@ $(function(){ | |||
| // backend's app.yaml file. | |||
| var backendHostUrl = '<your-backend-url>'; | |||
|
|
|||
| // [START config] | |||
There was a problem hiding this comment.
My understanding is that now that we have the sample tracker, we need to use tag titles that are non-ambiguous even across files. Perhaps something like [START gae_firenotes_config]?
Updated config tag titles to make them unambiguous
andrewsg
approved these changes
Jun 6, 2018
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE: https://cloud.google.com/appengine/docs/standard/python/authenticating-users-firebase-appengine#adding_the_firebase_authentication_user_interface
This fails because the projectId and messagingSenderId are missing. I have also added snippet anchors to include snippet in the doc.