Skip to content

Fix PubSub client conflict #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

bgsouza
Copy link

@bgsouza bgsouza commented Jul 5, 2018

Correcting the requirements.txt file conflict to proceed with the installation
$ pip install -r requirements.txt

Correcting the requirements.txt file conflict to proceed with the installation
$ pip install -r requirements.txt
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 5, 2018
@techieshark
Copy link

@bgsouza did you want to sign the CLA so this can merge and fix #1550 ?

@bgsouza
Copy link
Author

bgsouza commented Jul 16, 2018

@techieshark Yes! how can I do this?
I already did my registration to get the cla 'but do not know how to "re-process" here on GitHub

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 16, 2018
@bgsouza bgsouza closed this Jul 16, 2018
@bgsouza bgsouza reopened this Jul 16, 2018
@techieshark
Copy link

@bgsouza super, looks like that worked, now we just need someone (w/ write access) to review and merge.

@0x5d
Copy link

0x5d commented Aug 2, 2018

Hi! Any progress on this? I'd love to see this fix merged.

@bgsouza
Copy link
Author

bgsouza commented Aug 5, 2018

Hi @castillobgr, not yet :(
I am awaiting authorization for merge

Copy link
Author

@bgsouza bgsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I made a small fix on this file as it was breaking execution with python2

Copy link
Author

@bgsouza bgsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix version conflict

Copy link
Author

@bgsouza bgsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please review this commit

@techieshark
Copy link

It seems that master has been updated outside of this PR, but with the effect of fixing the issue - see https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/pubsub/cloud-client/requirements.txt

Should we close this?

@bgsouza bgsouza closed this Sep 12, 2018
@bgsouza bgsouza deleted the patch-1 branch September 12, 2018 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants