Bucket lock samples #1588
Bucket lock samples #1588
Conversation
|
|
||
| print('Retention policy for {} is now locked'.format(bucket_name)) | ||
| print('Retention policy Effective as of {}'.format( | ||
| bucket.retention_policy_effective_time)) |
There was a problem hiding this comment.
I get this error for this line. Any ideas?
AttributeError: 'Bucket' object has no attribute 'retention_policy_effective_time'
There was a problem hiding this comment.
To lock the retention policy you should use bucket.lock_retention_policy(). Review tests in google-cloud-python PR#5534 and w.r.t to this sample please review system.py line#1268.
There was a problem hiding this comment.
(I updated my comment -- made a mistake 😄)
There was a problem hiding this comment.
General feedback for other samples. I don't see patch operations being performed which means the metadata is only being updated locally and not in the service.
System tests Ref: https://github.com/GoogleCloudPlatform/google-cloud-python/pull/5534/files#diff-76380c4d34ce398e5075ab86d5305f5d
|
|
||
| print('Retention policy for {} is now locked'.format(bucket_name)) | ||
| print('Retention policy Effective as of {}'.format( | ||
| bucket.retention_policy_effective_time)) |
There was a problem hiding this comment.
To lock the retention policy you should use bucket.lock_retention_policy(). Review tests in google-cloud-python PR#5534 and w.r.t to this sample please review system.py line#1268.
There was a problem hiding this comment.
Thanks @billyjacobson!
I added some minor comments to the PR, lgtm overall!
Removing some unnecessary tests Generating the README Removing dependency on github branch
upgrading storage library version Updating readme
Correcting names of commands to be dashes and not underscores Updating readme
Uh oh!
There was an error while loading. Please reload this page.