Add IAM doc snippets #1609
Merged
Add IAM doc snippets #1609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add IAM service account keys snippets
Add IAM quickstart
Add IAM service account snippets
andrewsg
requested changes
Aug 20, 2018
.gitignore
Outdated
| @@ -20,3 +20,5 @@ secrets.tar | |||
| junit.xml | |||
| credentials.dat | |||
| .nox | |||
| env/ | |||
| .vscode/ | |||
iam/api-client/grantable_roles.py
Outdated
|
|
||
| # [START iam_view_grantable_roles] | ||
| def view_grantable_roles(full_resource_name): | ||
|
|
There was a problem hiding this comment.
Nit: Please remove the blank lines right after the def: here and elsewhere.
| resource = '//cloudresourcemanager.googleapis.com/projects/' + project | ||
| grantable_roles.view_grantable_roles(resource) | ||
| out, _ = capsys.readouterr() | ||
| assert 'Title:' in out |
iam/api-client/service_accounts.py
Outdated
| name=resource, body=service_account).execute() | ||
|
|
||
| print( | ||
| 'Updated display name for ' + service_account['email'] + |
There was a problem hiding this comment.
Please string formatting (for instance .format()) rather than addition, here and ideally everywhere else, or at least everywhere with more than two components.
.gitignore
Outdated
| @@ -20,3 +20,5 @@ secrets.tar | |||
| junit.xml | |||
| credentials.dat | |||
| .nox | |||
| env/ | |||
There was a problem hiding this comment.
Let's avoid adding env/ to gitignore; I'd recommend putting your env folder one level up so it's not under git as part of development workflow.
|
Addressed all feedback |
andrewsg
approved these changes
Aug 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.