Skip to content

Add firebase trigger samples #1651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 30, 2018
Merged

Add firebase trigger samples #1651

merged 3 commits into from
Aug 30, 2018

Conversation

ace-n
Copy link

@ace-n ace-n commented Aug 23, 2018

Add firebase trigger samples
997d7a4 
Change-Id: If677ab6aa788b3c134c11e155ee597537d181cd2
@ace-n ace-n requested a review from andrewsg August 23, 2018 20:13
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 23, 2018
samtstern
samtstern reviewed Aug 23, 2018
View reviewed changes
functions/firebase/main.py
# See the License for the specific language governing permissions and
# limitations under the License.

# [START functions_firebase_rtdb]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've got the same region tags twice (functions_firebase_rtdb). I don't think this will work...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK they concatenate together, which is the intended effect.

Downgrade to Python 2.7 to make CI pass
9cb17fb 
Change-Id: I3a20ff5e0fd7d2bb5986552f36570896f1833ee5
@ace-n ace-n added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 24, 2018
@ace-n
Copy link
Author

ace-n commented Aug 24, 2018 •
edited
Loading

Do not merge without adding tests

@andrewsg
Copy link
Member

Can you please ping the solutions team to ask if it's intended that Python 3 syntax is unlintable with our current setup?

@andrewsg
Copy link
Member

Do you need this reviewed before the tests are complete?

Add tests
4ef0cae 
Change-Id: Id9ea86c970ca3bbe51ead3aa02aeb35ce33486cf
@ace-n
Copy link
Author

ace-n commented Aug 28, 2018

  1. Pinged @SurferJeffAtGoogle RE Python3 linting
  2. Tests have been added, PTAL.

@ace-n ace-n removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 28, 2018
@ace-n ace-n merged commit eedc6d2 into master Aug 30, 2018
@ace-n ace-n deleted the fb-python branch August 30, 2018 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

+1 more reviewer

@samtstern samtstern samtstern left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ace-n @andrewsg @samtstern @googlebot