Skip to content

Remove ipython Python 2 modifier from requirements.txt #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2018
Merged

Remove ipython Python 2 modifier from requirements.txt #1675

merged 1 commit into from
Aug 31, 2018

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Aug 30, 2018

If ipython has tagged their packages correctly, then the modifier is not necessary. Sending a PR to check. Bug 113341391.

@tswast
Remove ipython Python 2 modifier from requirements.txt
cc4868d 
If ipython has tagged their packages correctly, then the modifier is not necessary. Sending a PR to check. Bug 113341391.
@tswast tswast requested a review from kurtisvg August 30, 2018 22:10
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 30, 2018
@tswast
Copy link
Contributor Author

tswast commented Aug 30, 2018

From the Travis output, we aren't actually testing on Python 2.7?

@kurtisvg
Copy link
Contributor

I didn't realize that was the case, but it appears to have been for a while.

@tswast
Copy link
Contributor Author

tswast commented Aug 31, 2018 •
edited
Loading

I've run the tests locally. Seems good to merge.

$ pytest *_test.py
 =========== test session starts ============
platform darwin -- Python 2.7.15, pytest-3.7.4, py-1.6.0, pluggy-0.7.1 -- 
   /Users/swast/.pyenv/versions/2.7.15/envs/temppy27/bin/python2.7
cachedir: .pytest_cache
rootdir: /Users/swast/src/python-docs-samples, inifile: pytest.ini
plugins: flaky-3.4.0
collected 6 items

authorized_view_tutorial_test.py::test_authorized_view_tutorial PASSED       [ 16%]
jupyter_tutorial_test.py::test_jupyter_tutorial PASSED                       [ 33%]
natality_tutorial_test.py::test_natality_tutorial PASSED                     [ 50%]
quickstart_test.py::test_quickstart PASSED                                   [ 66%]
simple_app_test.py::test_query_stackoverflow PASSED                          [ 83%]
user_credentials_test.py::test_auth_query_console PASSED                     [100%]

 =========== 6 passed in 85.03 seconds ===========

@tswast tswast merged commit 509601b into master Aug 31, 2018
@tswast tswast deleted the tswast-patch-1 branch August 31, 2018 18:01
@tswast tswast mentioned this pull request Sep 5, 2018
Closed
plamut pushed a commit to plamut/python-bigquery that referenced this pull request Jun 25, 2020
@tswast
Remove ipython Python 2 modifier from requirements.txt [(googleapis#1675
27babfe 
)](GoogleCloudPlatform/python-docs-samples#1675)

If ipython has tagged their packages correctly, then the modifier is not necessary. Sending a PR to check. Bug 113341391.
plamut pushed a commit to plamut/python-bigquery that referenced this pull request Jul 22, 2020
@tswast @plamut
Remove ipython Python 2 modifier from requirements.txt [(googleapis#1675
3b63b31 
)](GoogleCloudPlatform/python-docs-samples#1675)

If ipython has tagged their packages correctly, then the modifier is not necessary. Sending a PR to check. Bug 113341391.
shollyman pushed a commit to googleapis/python-bigquery that referenced this pull request Jul 22, 2020
@tswast @shollyman
Remove ipython Python 2 modifier from requirements.txt [(#1675)](Goog…
93d7a2b 
…leCloudPlatform/python-docs-samples#1675)

If ipython has tagged their packages correctly, then the modifier is not necessary. Sending a PR to check. Bug 113341391.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kurtisvg kurtisvg kurtisvg approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tswast @kurtisvg @googlebot