GCF SQL: Use proper environment variables #1703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Spoke with @jasonpolites and @stew-r internally - we should ditch the env. var approach (except perhaps for Node, since |
Change-Id: Ibe4d6ff8d6dc928bce8c62178d52e3c5485899be
Change-Id: Id5d50643012e2bb7f3f34cd1dc69c3385d62dc7f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Missed a spot in #1655)
Replace
SUPERVISOR_HOSTNAMEwith something more stable@jasonpolites please review (and tell me if there's a better way)