Skip to content

Add Composer samples that explicitly call python2 #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2018
Merged

Add Composer samples that explicitly call python2 #1711

merged 2 commits into from
Sep 18, 2018

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Sep 17, 2018

Please review @TrevorEdwards

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 17, 2018
@tswast
Copy link
Contributor Author

tswast commented Sep 17, 2018

Seeing as the tests don't seem to be running. Here's the nox ouput:

$ nox -k "composer and not appengine"
...
====================================== 9 passed, 1 skipped, 5 warnings in 7.70 seconds =======================================
nox > Session py36(sample='./composer/workflows') was successful.
nox > Running session readmegen(sample='./composer/rest')
nox > /Users/swast/.pyenv/versions/3.6.4/envs/dev/bin/python -m virtualenv /Users/swast/src/python-docs-samples/.nox/readmegen-sample-composer-rest
nox > chdir /Users/swast/src/python-docs-samples
nox > pip install --upgrade jinja2 pyyaml
nox > pip install --upgrade -r ./composer/rest/requirements.txt
nox > python scripts/readme-gen/readme_gen.py ./composer/rest/README.rst.in
nox > Session readmegen(sample='./composer/rest') was successful.
nox > Running session readmegen(sample='./composer/workflows')
nox > /Users/swast/.pyenv/versions/3.6.4/envs/dev/bin/python -m virtualenv /Users/swast/src/python-docs-samples/.nox/readmegen-sample-composer-workflows
nox > chdir /Users/swast/src/python-docs-samples
nox > pip install --upgrade jinja2 pyyaml
nox > pip install --upgrade -r ./composer/workflows/requirements.txt
nox > python scripts/readme-gen/readme_gen.py ./composer/workflows/README.rst.in
nox > Session readmegen(sample='./composer/workflows') was successful.
nox > Ran multiple sessions:
nox > * lint(sample='./composer/data'): success
nox > * lint(sample='./composer/rest'): success
nox > * lint(sample='./composer/tools'): success
nox > * lint(sample='./composer/workflows'): success
nox > * lint(sample='./composer/workflows/dependencies'): success
nox > * py27(sample='./composer/rest'): success
nox > * py27(sample='./composer/tools'): success
nox > * py27(sample='./composer/workflows'): success
nox > * py36(sample='./composer/rest'): success
nox > * py36(sample='./composer/tools'): success
nox > * py36(sample='./composer/workflows'): success
nox > * readmegen(sample='./composer/rest'): success
nox > * readmegen(sample='./composer/workflows'): success

@tswast tswast force-pushed the b112707720-composer branch from 1e4c65a to 99b82af Compare September 18, 2018 20:28
@tswast tswast merged commit b4098b6 into master Sep 18, 2018
@tswast tswast deleted the b112707720-composer branch September 18, 2018 20:39
TrevorEdwards
TrevorEdwards reviewed Sep 21, 2018
View reviewed changes
composer/workflows/pythonvirtualenvoperator_python2_test.py
from . import unit_testing


@pytest.mark.skipif(sys.version_info >= (3, 0), reason="requires Python 2")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the DAG should be importable from Python3 like the other one in this commit, unless I'm missing something

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. #1714

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@TrevorEdwards TrevorEdwards TrevorEdwards left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tswast @TrevorEdwards @googlebot