Skip to content

Remove unused and outdated Natural Language samples #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 16, 2018
Merged

Remove unused and outdated Natural Language samples #1715

merged 5 commits into from
Oct 16, 2018

Conversation

alixhami
Copy link
Contributor

Removes unused and outdated tutorials and samples. Specifically:

  • v1beta2/ folder because no samples are in beta
  • Tutorials using googleapiclient.discovery

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2018
@alixhami alixhami changed the title Remove unused samples Remove unused and outdated Natural Language samples Sep 21, 2018
@beccasaurus beccasaurus requested review from dizcology and nnegrey and removed request for beccasaurus September 24, 2018 18:08
nnegrey
nnegrey approved these changes Sep 25, 2018
View reviewed changes
Copy link
Contributor

@nnegrey nnegrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dizcology, what are your thoughts on this?

dizcology
dizcology reviewed Sep 25, 2018
View reviewed changes
Copy link
Member

@dizcology dizcology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alixhami Please confirm that the samples with region tags (the beta samples) are not being used in the docs.

The three samples movie_nl, ocr_nl, and syntaxz_triples are tutorials that do not have equivalent samples using google-cloud-language. I would suggest keeping them for now.

@alixhami
Copy link
Contributor Author

I confirmed that they are not being used in the docs.

Aren't the tutorials not using a currently recommended way of interacting with the API? What is in these tutorials that is missing from the docs? If there are gaps in the docs we should create content using google-cloud-language to address that.

@beccasaurus
Copy link
Contributor

My recommendation would be to do away with all stale code using googleapiclient.discovery. It's confusing to users.

Also, out standard practice is:

if it's not in the docs (either cloud.google.com product pages or cloud.google.com/community) then it's safe to delete

If we want to keep code, it needs to be published somewhere

LGTM

@alixhami alixhami force-pushed the remove-unused-samples branch from 1a16f92 to be53b9f Compare October 9, 2018 22:06
@alixhami
Copy link
Contributor Author

cc @beccasaurus

@alixhami alixhami requested a review from beccasaurus October 16, 2018 22:46
@alixhami alixhami force-pushed the remove-unused-samples branch from be53b9f to 7d89c0b Compare October 16, 2018 22:46
beccasaurus
beccasaurus approved these changes Oct 16, 2018
View reviewed changes
Copy link
Contributor

@beccasaurus beccasaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥

@alixhami alixhami merged commit 59a5073 into master Oct 16, 2018
@alixhami alixhami deleted the remove-unused-samples branch October 16, 2018 22:51
hkdevandla pushed a commit to hkdevandla/python-language that referenced this pull request Sep 26, 2020
@alixhami
Remove unused and outdated Natural Language samples [(#1715)](GoogleC…
b9af39a 
…loudPlatform/python-docs-samples#1715)

* remove unused beta entity sentiment samples

* remove unused beta samples

* remove v1beta2 directory

* remove outdated unused tutorial

* removes remaining googleapiclient.discovery tutorials
busunkim96 pushed a commit to googleapis/python-language that referenced this pull request Sep 29, 2020
@alixhami @busunkim96
Remove unused and outdated Natural Language samples [(#1715)](GoogleC…
9b3ecba 
…loudPlatform/python-docs-samples#1715)

* remove unused beta entity sentiment samples

* remove unused beta samples

* remove v1beta2 directory

* remove outdated unused tutorial

* removes remaining googleapiclient.discovery tutorials
m-strzelczyk pushed a commit that referenced this pull request Nov 18, 2022
@alixhami @busunkim96
Remove unused and outdated Natural Language samples [(#1715)](#1715)
dac091d 
* remove unused beta entity sentiment samples

* remove unused beta samples

* remove v1beta2 directory

* remove outdated unused tutorial

* removes remaining googleapiclient.discovery tutorials
@m-strzelczyk m-strzelczyk mentioned this pull request Nov 18, 2022
Merged
8 tasks
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Jul 6, 2023
@alixhami @busunkim96
Remove unused and outdated Natural Language samples [(#1715)](GoogleC…
6de0376 
…loudPlatform/python-docs-samples#1715)

* remove unused beta entity sentiment samples

* remove unused beta samples

* remove v1beta2 directory

* remove outdated unused tutorial

* removes remaining googleapiclient.discovery tutorials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dizcology dizcology dizcology left review comments

@beccasaurus beccasaurus beccasaurus approved these changes

@nnegrey nnegrey nnegrey approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alixhami @beccasaurus @dizcology @nnegrey @googlebot