Skip to content

Fix serving static files on production #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2018
Merged

Fix serving static files on production #1730

merged 2 commits into from
Oct 10, 2018

Conversation

iotmani
Copy link
Contributor

@iotmani iotmani commented Oct 3, 2018

Django collectstatic adds files to static/ folder rather than static_files/.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 3, 2018
@iotmani
Copy link
Contributor Author

iotmani commented Oct 10, 2018

@andrewsg if you can take a look at this also 👍

@andrewsg andrewsg requested a review from michaelawyu October 10, 2018 20:28
@andrewsg
Copy link
Member

@michaelawyu Same here, please check on this and if it's correct, look into why our tests or other process didn't catch it. Thanks @iotmani!

@michaelawyu michaelawyu merged commit dacf009 into GoogleCloudPlatform:master Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@michaelawyu michaelawyu michaelawyu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iotmani @andrewsg @michaelawyu @googlebot