Skip to content

[Asset] Add quickstart code for BatchGetAssetsHistory API. #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 28, 2018
Merged

[Asset] Add quickstart code for BatchGetAssetsHistory API. #1867

merged 10 commits into from
Nov 28, 2018

Conversation

peter-zheng-g
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 22, 2018
gguuss
gguuss suggested changes Nov 27, 2018
View reviewed changes
@gguuss
Copy link
Contributor

gguuss commented Nov 28, 2018

I think you need a different member of the response object for tests to pass.

@peter-zheng-g
Copy link
Contributor Author

I think you need a different member of the response object for tests to pass.
Thanks. Sorry didn't get what you meant at the beginning. Now the code has been updated and the test are passing.

gguuss
gguuss reviewed Nov 28, 2018
View reviewed changes
gguuss
gguuss approved these changes Nov 28, 2018
View reviewed changes
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM

@peter-zheng-g
Copy link
Contributor Author

I've resolved the nit. Thanks!

@gguuss gguuss merged commit 8f28cb6 into GoogleCloudPlatform:master Nov 28, 2018
@peter-zheng-g
Copy link
Contributor Author

Thanks!

arithmetic1728 pushed a commit to googleapis/python-asset that referenced this pull request Jul 31, 2020
@peter-zheng-g @gguuss
[Asset] Add quickstart code for BatchGetAssetsHistory API. [(#1867)](G…
90065cf 
…oogleCloudPlatform/python-docs-samples#1867)

* [Asset] Test: fix bucket clean up logic.
* [Asset] Add quickstart code for BatchGetAssetsHistory API.
busunkim96 pushed a commit to googleapis/python-asset that referenced this pull request Aug 4, 2020
@peter-zheng-g @busunkim96
[Asset] Add quickstart code for BatchGetAssetsHistory API. [(#1867)](G…
85967d2 
…oogleCloudPlatform/python-docs-samples#1867)

* [Asset] Test: fix bucket clean up logic.
* [Asset] Add quickstart code for BatchGetAssetsHistory API.
engelke pushed a commit that referenced this pull request Nov 28, 2022
@peter-zheng-g @busunkim96
[Asset] Add quickstart code for BatchGetAssetsHistory API. [(#1867)](#…
fd2e661 
…1867)

* [Asset] Test: fix bucket clean up logic.
* [Asset] Add quickstart code for BatchGetAssetsHistory API.
dandhlee pushed a commit that referenced this pull request Nov 29, 2022
@peter-zheng-g @dandhlee
[Asset] Add quickstart code for BatchGetAssetsHistory API. [(#1867)](#…
4dfd612 
…1867)

* [Asset] Test: fix bucket clean up logic.
* [Asset] Add quickstart code for BatchGetAssetsHistory API.
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 21, 2023
@peter-zheng-g @busunkim96
[Asset] Add quickstart code for BatchGetAssetsHistory API. [(#1867)](G…
1814d32 
…oogleCloudPlatform/python-docs-samples#1867)

* [Asset] Test: fix bucket clean up logic.
* [Asset] Add quickstart code for BatchGetAssetsHistory API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gguuss gguuss gguuss approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peter-zheng-g @gguuss @googlebot