Skip to content

Be consistent about how we run samples locally #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 25, 2019
Merged

Be consistent about how we run samples locally #1881

merged 6 commits into from
Jan 25, 2019

Conversation

di
Copy link
Member

@di di commented Nov 30, 2018

This PR ensures that we're calling app.run() in a consistent way across all standard_python37 samples (including the comments).

There's a few other places where we might want to update as well, but I'm not familiar enough with these samples to say for sure that we should:

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2018
engelke
engelke approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelke engelke merged commit aae2eae into GoogleCloudPlatform:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@engelke engelke engelke approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@di @engelke @googlebot