Skip to content

Firestore watch samples #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 19, 2018
Merged

Firestore watch samples #1883

merged 6 commits into from
Dec 19, 2018

Conversation

frankyn
Copy link
Contributor

@frankyn frankyn commented Dec 1, 2018

Pending release of Firestore Python client library.

Internal tracking bug: 76394377

@frankyn frankyn added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 1, 2018
@frankyn frankyn requested a review from kurtisvg December 1, 2018 00:17
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 1, 2018
@frankyn frankyn changed the title [Do Not Merge] Firestore watch samples [Do Not Merge] [WIP] Firestore watch samples Dec 1, 2018
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minus local requirement in requirements.txt

@@ -1 +1,2 @@
google-cloud-firestore==0.30.0
#google-cloud-firestore==0.30.0
../../../google-cloud-python/firestore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be reverted before it can be merged.

@frankyn frankyn removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 18, 2018
@frankyn frankyn changed the title [Do Not Merge] [WIP] Firestore watch samples Firestore watch samples Dec 18, 2018
@kurtisvg kurtisvg merged commit a64e4af into master Dec 19, 2018
@kurtisvg kurtisvg deleted the firestore-watch branch December 19, 2018 01:12
@kurtisvg kurtisvg restored the firestore-watch branch December 19, 2018 01:12
@gguuss gguuss deleted the firestore-watch branch July 30, 2019 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants