Skip to content

Conversation

daniel-sanche
Copy link
Member

Updated all samples to use the new libraries

tracking bug: b/120216809

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2018
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The asymmetric samples all have comments saying that they work on key IDs, but actually require key version IDs. The tests all work with key versions, so they pass.

Please address the comments and update.

@daniel-sanche
Copy link
Member Author

@engelke I addressed your comments, let me know if there's anything else

@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2019
@daniel-sanche daniel-sanche merged commit 6f9eacf into master Jan 7, 2019
@daniel-sanche daniel-sanche deleted the kms-gapic-update branch January 8, 2019 23:45
busunkim96 pushed a commit to googleapis/python-kms that referenced this pull request Jun 4, 2020
rsamborski pushed a commit that referenced this pull request Nov 8, 2022
* updated kms samples to use new gapic client library
rsamborski pushed a commit that referenced this pull request Nov 11, 2022
* updated kms samples to use new gapic client library
rsamborski pushed a commit that referenced this pull request Nov 14, 2022
* updated kms samples to use new gapic client library
dandhlee pushed a commit that referenced this pull request Nov 14, 2022
* updated kms samples to use new gapic client library
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants