Added code samples for stored infoTypes. #1934
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The samples were modeled after triggers.py and adapted to stored infoTypes. Note that this does not include code samples for actually using them - those will be added later.
|
Please take a look. |
gguuss
suggested changes
Jul 24, 2019
| 'field': {'name': bq_input_table_field}, | ||
| } | ||
| } | ||
| create_stored_info_type(project, dictionary_config, |
There was a problem hiding this comment.
As alternative formatting, you could avoid the hanging indent:
create_stored_info_type(
project, dictionary_config, stored_info_type_id=stored_info_type_id,
display_name=display_name, description=description)| @@ -0,0 +1,99 @@ | |||
| # Copyright 2017 Google Inc. | |||
There was a problem hiding this comment.
If this is a new file, add this as 2019 instead of 2017
| bucket.delete() | ||
|
|
||
|
|
||
| def test_create_list_and_delete_stored_info_type(bucket, capsys): |
There was a problem hiding this comment.
Probably fine as-is but consider separating the create/delete and create/list/delete tests.
|
from mcdaub: Hi Andrew, I originally submitted that PR in 2018 and then changed teams in early 2019. Because nobody responded to my PR request for over a month, I stopped working on it and no longer have the bandwidth to work on it since my new team is not associated with the code. You can either close the PR or ask my old team to open a new one with the same changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DLP team is in the process of expanding code samples to include features that we have launched since the initial samples were written.
This pull request adds code samples for the recently launched stored infoTypes feature. The samples were modeled after triggers.py and adapted to stored infoTypes. Note that this does not include code samples for actually using them - those will be added later.