Skip to content

Conversation

averikitsch
Copy link
Contributor

No description provided.

@averikitsch averikitsch requested a review from andrewsg January 11, 2019 18:13
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 11, 2019
@averikitsch averikitsch added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 11, 2019
@averikitsch averikitsch removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 11, 2019
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few optional comments.



def test_create_job(capsys):
create_result = create_job.create_scheduler_job(TEST_PROJECT_ID,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing the hanging indent:

create_result = create_job.create_scheduler_job(
    TEST_PROJECT_ID, TEST_LOCATION, 'my-service')

@@ -0,0 +1,42 @@
# Copyright 2018 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Optional) Consider updating to 2019 as this is first publish

@averikitsch averikitsch merged commit 5ef79a6 into master Jul 24, 2019
@averikitsch averikitsch deleted the scheduler branch July 24, 2019 21:54
danoscarmike pushed a commit to danoscarmike/python-scheduler that referenced this pull request Aug 19, 2020
…samples#1968)

* scheduler sample

* scheduler tutorial draft

* create and delete requests completed

* updated region tag

* update error

* fix linting

* Update styling

* Update license

* Update license

* Update license

* Update license
busunkim96 pushed a commit to googleapis/python-scheduler that referenced this pull request Aug 20, 2020
…samples#1968)

* scheduler sample

* scheduler tutorial draft

* create and delete requests completed

* updated region tag

* update error

* fix linting

* Update styling

* Update license

* Update license

* Update license

* Update license
MiaCY pushed a commit that referenced this pull request Apr 11, 2023
* scheduler sample

* scheduler tutorial draft

* create and delete requests completed

* updated region tag

* update error

* fix linting

* Update styling

* Update license

* Update license

* Update license

* Update license
dandhlee pushed a commit that referenced this pull request Apr 22, 2023
* scheduler sample

* scheduler tutorial draft

* create and delete requests completed

* updated region tag

* update error

* fix linting

* Update styling

* Update license

* Update license

* Update license

* Update license
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Sep 22, 2023
…samples#1968)

* scheduler sample

* scheduler tutorial draft

* create and delete requests completed

* updated region tag

* update error

* fix linting

* Update styling

* Update license

* Update license

* Update license

* Update license
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants