Skip to content

Update Cloud SQL connectivity sample region tags. #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 8, 2019
Merged

Update Cloud SQL connectivity sample region tags. #1993

merged 4 commits into from
Feb 8, 2019

Conversation

kurtisvg
Copy link
Contributor

@kurtisvg kurtisvg commented Feb 4, 2019

Update Cloud SQL region tags and fix env var check to match README.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 4, 2019
@frankyn
Copy link
Contributor

frankyn commented Feb 4, 2019

@kurtisvg is there a CL with staged docs associated to this PR?

@kurtisvg
Copy link
Contributor Author

kurtisvg commented Feb 4, 2019

@frankyn Not yet - I'm going down the list updating samples.

@frankyn
Copy link
Contributor

frankyn commented Feb 4, 2019

Gotcha, I'll approve once it's staged.

@kurtisvg kurtisvg merged commit edaf68a into master Feb 8, 2019
@kurtisvg kurtisvg deleted the cloudsql-connect branch February 8, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@frankyn frankyn frankyn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@frankyn frankyn

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kurtisvg @frankyn @googlebot