storage: S3 SDK sample to list buckets #2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
November 1, 2018 16:21
engelke
approved these changes
Feb 25, 2019
|
|
||
| .. code-block:: bash | ||
|
|
||
| $ git clone https://github.com/GoogleCloudPlatform/python-docs-samples.git |
There was a problem hiding this comment.
Suggest you add the cd command after the clone.
There was a problem hiding this comment.
Also, should this tell the user to set the authentication environment variables?
There was a problem hiding this comment.
I modified the example to pass in credentials using CLI parameter.
I looked at other samples and I didn't see cd ./../ when generating README's with templates. For consistency, I'm going to keep as is as it impacts other samples.
|
Thanks @engelke, I updated the PR with credentials necessary to test this sample. PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The PR adds a new sample to list GCS buckets using the S3 SDK in Python.