Skip to content

Conversation

dizcology
Copy link
Member

Video Intelligence API streaming samples.

@dizcology dizcology requested a review from nnegrey March 14, 2019 20:02
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 14, 2019
@@ -274,6 +288,290 @@ def track_objects(path):
return object_annotations


def detect_labels_streaming(path):
# [START video_streaming_label_detection_beta]
from google.cloud import videointelligence_v1p3beta1 as videointelligence
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add a commented out variable path if you don't include the method def.

// path = 'path_to_file'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

break

for annotation in response.annotation_results.shot_annotations:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: empty line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@nnegrey nnegrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the 1 thing is needed to add the commented out variables to make the code copy-paste runnable. But looks good.

@dizcology dizcology merged commit da04c4b into GoogleCloudPlatform:master Mar 18, 2019
@dizcology dizcology deleted the video-streaming branch March 18, 2019 19:38
busunkim96 pushed a commit to busunkim96/python-videointelligence that referenced this pull request May 20, 2020
…-samples#2047)

* add video streaming samples

* address review comments

* flake

* flake

* flake
danoscarmike pushed a commit to googleapis/python-videointelligence that referenced this pull request Sep 30, 2020
…-samples#2047)

* add video streaming samples

* address review comments

* flake

* flake

* flake
dizcology added a commit that referenced this pull request Sep 11, 2023
* add video streaming samples

* address review comments

* flake

* flake

* flake
leahecole pushed a commit that referenced this pull request Sep 15, 2023
* add video streaming samples

* address review comments

* flake

* flake

* flake
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Sep 22, 2023
…-samples#2047)

* add video streaming samples

* address review comments

* flake

* flake

* flake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants