Skip to content

Changes from CHAR to VARCHAR on Cloud SQL example #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2019
Merged

Changes from CHAR to VARCHAR on Cloud SQL example #2080

merged 2 commits into from
Apr 2, 2019

Conversation

gabidavila
Copy link
Contributor

Using CHAR was bringing extra spaces on the frontend for comparison and leading to display wrong information.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 2, 2019
@kurtisvg kurtisvg merged commit 535bc41 into GoogleCloudPlatform:master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kurtisvg kurtisvg kurtisvg approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabidavila @kurtisvg @googlebot