Skip to content

Remove deprecated migration scripts #2119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 30, 2019
Merged

Remove deprecated migration scripts #2119

merged 6 commits into from
Apr 30, 2019

Conversation

leahecole
Copy link
Collaborator

Per request of the composer team, remove these migration scripts

@leahecole leahecole requested a review from tswast April 24, 2019 21:38
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 24, 2019
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think I saw it's already removed from the docs, right?

@tswast
Copy link
Contributor

tswast commented Apr 24, 2019

Should we add a README file pointing to the in-place upgrade guide?

@leahecole
Copy link
Collaborator Author

Yes, we totally should. I'll update the readme now.

@tswast
Copy link
Contributor

tswast commented Apr 30, 2019

LGTM!

@leahecole leahecole merged commit ccc8fda into GoogleCloudPlatform:master Apr 30, 2019
@jbielick
Copy link

This script is still the only way to migrate from an old environment to a new one though, right? For example, our composer environment is not VPC-native, private IP, etc. I suppose that's an edge case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants