-
Notifications
You must be signed in to change notification settings - Fork 6.5k
IAM: added snippet for remove member #2165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let me know if you want me to merge or if you want to change the member in your test first.
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
I went ahead and pushed a few fixes for the tests to your fork. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
iam/api-client/access_test.py
Outdated
out, _ = capsys.readouterr() | ||
assert 'etag' in out | ||
|
||
policy = access.set_policy(project, policy) | ||
policy = access.modify_policy_remove_member(policy, gcp_role, member) | ||
out, _ = capsys.readouterr() | ||
assert 'etag' in out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing this test failing in Python 2.
Example code for removing a member in IAM policy.