Skip to content

IAM: added snippet for remove member #2165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 14, 2019
Merged

IAM: added snippet for remove member #2165

merged 6 commits into from
Aug 14, 2019

Conversation

DSdatsme
Copy link
Contributor

Example code for removing a member in IAM policy.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 18, 2019
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let me know if you want me to merge or if you want to change the member in your test first.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 14, 2019
@gguuss
Copy link
Contributor

gguuss commented Aug 14, 2019

I went ahead and pushed a few fixes for the tests to your fork.

@gguuss gguuss added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 14, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

out, _ = capsys.readouterr()
assert 'etag' in out

policy = access.set_policy(project, policy)
policy = access.modify_policy_remove_member(policy, gcp_role, member)
out, _ = capsys.readouterr()
assert 'etag' in out
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing this test failing in Python 2.

@gguuss gguuss merged commit 9226981 into GoogleCloudPlatform:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants