Use print() function in both Python 2 and Python 3 #2234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Legacy __print__ statements are syntax errors in Python 3 but __print()__ function works as expected in both Python 2 and Python 3.
gguuss
suggested changes
Jul 17, 2019
| @@ -49,15 +54,15 @@ def _get_plural_forms(js_translations): | |||
| for l in js_translations._catalog[''].split('\n'): | |||
| if l.startswith('Plural-Forms:'): | |||
| plural = l.split(':', 1)[1].strip() | |||
| print "plural is %s" % plural | |||
| print("plural is %s" % plural) | |||
There was a problem hiding this comment.
Prefer string formatter and single quotes:
print(`plural is {}`.format(plural))
There was a problem hiding this comment.
python/black (think gofmt for Python) is reformatting code to prefer " over ' but I will make the requested change.
There was a problem hiding this comment.
We'll consider this alternative style; I don't personally have a strong opinion either way. Thank you for the pointers, also thanks a ton for the fixes!
There was a problem hiding this comment.
Regarding python/black and quotes, according to the style guide it looks like some teams are using yapf.
|
@cclauss Friendly ping, happy to accept your enhancements once you've applied the style we prefer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy print statements are syntax errors in Python 3 but print() function works as expected in both Python 2 and Python 3.