Skip to content

Add needed parameter #2236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2019
Merged

Add needed parameter #2236

merged 1 commit into from
Jul 25, 2019

Conversation

engelke
Copy link
Contributor

@engelke engelke commented Jun 24, 2019

The tracer won't always send traces unless a sampler is specified. This one sends every trace.

@engelke
Add needed parameter
426679c 
The tracer won't always send traces unless a sampler is specified. This one sends every trace.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 24, 2019
@engelke engelke requested a review from fhinkel June 24, 2019 22:45
gguuss
gguuss approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelke engelke merged commit 968c992 into master Jul 25, 2019
@engelke engelke deleted the engelke-patch-3 branch July 25, 2019 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

+1 more reviewer

@gguuss gguuss gguuss approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@engelke @fhinkel @gguuss @googlebot